NOT ACTIVE ANY MORE
Reason
Referring external images did not work, even after updating application.conf
app.perm.externalImages=allow
It showed, that the ImageMacro code is broken, as it searches the indexOf('.') within the image link to locate the extension. The extension is then cut off. Unfortunalty, on www.somewhere.com/image.jpg, the extension was not found correctly and an incorrect html link was produced (http://www.)
Updated org.snipsnap.snip.filter.macro.ImageMacro
public void execute(Writer writer, MacroParameter params)
throws IllegalArgumentException, IOException { [...] // MOVED EXTENSION LOOKUP INTO ELSE
if (img.startsWith("http://")) {
if (config.allowExternalImages()) {
SnipLink.appendExternalImage(buffer, img, align);
}
} else {
// MW CHANGED MOVED EXTENSION DETECTION AFTER HTTP DETECTION
// Does the name contain an extension?
int dotIndex = img.indexOf('.');
if (-1 != dotIndex) {
ext = img.substring(dotIndex + 1);
img = img.substring(0, dotIndex);
}
[...]
more changes...
++ vox.machina ++
RSS Feed
post to del.icio.us
Stats: 1176 snips by 16 users
